[ 
https://issues.apache.org/jira/browse/YARN-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864972#comment-15864972
 ] 

Weiwei Yang commented on YARN-6177:
-----------------------------------

Thanks [~gtCarrera9] for the quick review,

bq. are we catching every throwable and swallow them if 
timelineServiceBestEffort is set to true?

that's definitely not my intention! thanks for pointing this out, I am going to 
correct this and upload a new patch shortly.

bq. Meanwhile, we can improve the output message if we hit NoClassDefFoundError 
to hint users to disable timeline service?

I am proposing the error message like following
"Exception in thread "main" java.lang.NoClassDefFoundError: 
com/sun/jersey/api/client/config/ClientConfig. It appears that the timeline 
client failed to initiate because an incompatible dependency in classpath. If 
timeline service is optional to this client, try to work around by setting 
yarn.timeline-service.client.best-effort to true."
Use timeline best effort flag seems a better option for me than disabling it, 
are you suggesting we should still ask users to disable it?

> Yarn client should exit with an informative error message if an incompatible 
> Jersey library is used at client
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6177
>                 URL: https://issues.apache.org/jira/browse/YARN-6177
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 3.0.0-alpha2
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: spark2-job-output-after-besteffort.out, 
> spark2-job-output-after.out, spark2-job-output-before.out, 
> YARN-6177.01.patch, YARN-6177.02.patch, YARN-6177.03.patch
>
>
> Per discussion in YARN-5271, lets provide an error message to suggest user to 
> disable timeline service instead of disabling for them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to