[ 
https://issues.apache.org/jira/browse/YARN-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702753#comment-13702753
 ] 

Hadoop QA commented on YARN-366:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12591331/YARN-366-6.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests:

                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch
                  
org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerReboot
                  
org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
                  
org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerResync
                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
                  
org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown
                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor
                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.TestContainerManager
                  org.apache.hadoop.yarn.server.nodemanager.TestEventFlow
                  org.apache.hadoop.yarn.server.TestContainerManagerSecurity
                  org.apache.hadoop.yarn.server.TestDiskFailures

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1431//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1431//console

This message is automatically generated.
                
> Add a tracing async dispatcher to simplify debugging
> ----------------------------------------------------
>
>                 Key: YARN-366
>                 URL: https://issues.apache.org/jira/browse/YARN-366
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-366-1.patch, YARN-366-2.patch, YARN-366-3.patch, 
> YARN-366-4.patch, YARN-366-5.patch, YARN-366-6.patch, YARN-366.patch
>
>
> Exceptions thrown in YARN/MR code with asynchronous event handling do not 
> contain informative stack traces, as all handle() methods sit directly under 
> the dispatcher thread's loop.
> This makes errors very difficult to debug for those who are not intimately 
> familiar with the code, as it is difficult to see which chain of events 
> caused a particular outcome.
> I propose adding an AsyncDispatcher that instruments events with tracing 
> information.  Whenever an event is dispatched during the handling of another 
> event, the dispatcher would annotate that event with a pointer to its parent. 
>  When the dispatcher catches an exception, it could reconstruct a "stack" 
> trace of the chain of events that led to it, and be able to log something 
> informative.
> This would be an experimental feature, off by default, unless extensive 
> testing showed that it did not have a significant performance impact.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to