[ 
https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867376#comment-15867376
 ] 

Varun Saxena commented on YARN-6156:
------------------------------------

For unmanaged AM as AM blacklisting is not done, it is equivalent to 
blacklisting being disabled for this app. Hence we do not need to create a 
SimpleBlacklistManager object in RMAppImpl#createNewAttempt. We can create 
DisabledBlacklistManager object instead. 
This change has also been made as part of this JIRA.

> AM blacklisting to consider node label partition
> ------------------------------------------------
>
>                 Key: YARN-6156
>                 URL: https://issues.apache.org/jira/browse/YARN-6156
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, 
> YARN-6156.0003.patch, YARN-6156.0004.patch, YARN-6156.0005.patch, 
> YARN-6156.0006.patch
>
>
> As per the current implementation for AM blacklisting, disabling is based on 
> complete cluster resource.
> Incase of partitioned cluster though, nodes applicable for AM labels only 
> should be considered as total nodes.
> Additionally for unmanaged AM as AM blacklisting is not done, it is 
> equivalent to blacklisting being disabled for this app. Hence we do not need 
> to create a SimpleBlacklistManager object in RMAppImpl#createNewAttempt. 
> We can create DisableBlacklistManager object instead.
> {code}
>     BlacklistManager currentAMBlacklist;
>     if (currentAttempt != null) {
>       currentAMBlacklist = currentAttempt.getAMBlacklist();
>     } else {
>       if (amBlacklistingEnabled) {
>         currentAMBlacklist = new SimpleBlacklistManager(
>             scheduler.getNumClusterNodes(), blacklistDisableThreshold);
>       } else {
>         currentAMBlacklist = new DisabledBlacklistManager();
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to