[ 
https://issues.apache.org/jira/browse/YARN-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yufei Gu updated YARN-6202:
---------------------------
    Description: 
Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) always 
be true no matter what value in configuration files. This misleads users. Two 
solutions: 
# Remove the configuration item and provide a method to allow 
{{exitOnDispatchException}}/{{shouldExitOnError}} to be false to enable related 
unit tests, the assumption is there is no need for false value in a real 
daemon, this is valid according to MAPREDUCE-3634 which introduce the 
configuration item.
# Make it default true instead of false, so that we don't need to hard code it 
to be true in RM and NM, it is still configurable, and also provide method to 
enable related unit tests.

Other than that, the code around it needs to refactor. {{public static final}} 
for a variable of interface isn't necessary, and YARN related configure item 
should be in class YarnConfiguration. 

  was:
Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) always 
be true no matter what value in configuration files. This misleads users. Two 
solutions: 
# Remove the configuration item but also allow it to be false to enable some 
unit tests, the assumption is there is no need for false value in product env.
# Make it default true instead of false, so that we don't need to hard code in 
RM and NM, it is still configurable. 

Other than that, the code around it needs to refactor. {{public static final}} 
for a variable of interface isn't necessary, and YARN related configure item 
should be in class YarnConfiguration.


> Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded
> -------------------------------------------------------------------------
>
>                 Key: YARN-6202
>                 URL: https://issues.apache.org/jira/browse/YARN-6202
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>
> Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) 
> always be true no matter what value in configuration files. This misleads 
> users. Two solutions: 
> # Remove the configuration item and provide a method to allow 
> {{exitOnDispatchException}}/{{shouldExitOnError}} to be false to enable 
> related unit tests, the assumption is there is no need for false value in a 
> real daemon, this is valid according to MAPREDUCE-3634 which introduce the 
> configuration item.
> # Make it default true instead of false, so that we don't need to hard code 
> it to be true in RM and NM, it is still configurable, and also provide method 
> to enable related unit tests.
> Other than that, the code around it needs to refactor. {{public static 
> final}} for a variable of interface isn't necessary, and YARN related 
> configure item should be in class YarnConfiguration. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to