[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874915#comment-15874915 ]
Varun Saxena edited comment on YARN-6069 at 2/20/17 6:48 PM: ------------------------------------------------------------- Thanks [~rohithsharma] for the patch. Core changes look fine to me. Few comments on the .md file # "See also \[HttpAuthentication\](../../hadoop-project-dist/hadoop-common/HttpAuthentication.html)" jumps to the page. We can directly jump to CORS section in the page by mentioning {{../../hadoop-project-dist/hadoop-common/HttpAuthentication.html#CORS]} # Maybe modify the documentation to something like under? {code} To enable cross-origin support (CORS) for the Timeline Service v.2, please set the following configuration parameters: In core-site.xml, add org.apache.hadoop.security.HttpCrossOriginFilterInitializer to hadoop.http.filter.initializers. In yarn-site.xml, set yarn.timeline-service.http-cross-origin.enabled to true. For other configurations used for cross-origin support, refer to [HttpAuthentication](../../hadoop-project-dist/hadoop-common/HttpAuthentication.html#CORS). Please note that for timeline service, configuration property, yarn.timeline-service.http-cross-origin.enabled, if set to true, overrides configuration property hadoop.http.cross-origin.enabled. Both yarn.timeline-service.http-cross-origin.enabled and hadoop.http.cross-origin.enabled must be set to false to disable cross-origin support. {code} Also yarn.timeline-service.http-cross-origin.enabled is not present in yarn-default.xml from before. Should it be there? was (Author: varun_saxena): Thanks [~rohithsharma] for the patch. Core changes look fine to me. Few comments on the .md file # "See also \[HttpAuthentication\](../../hadoop-project-dist/hadoop-common/HttpAuthentication.html)" jumps to the page. We can directly jump to CORS section in the page by mentioning {{../../hadoop-project-dist/hadoop-common/HttpAuthentication.html#CORS]} # Maybe modify the documentation to something like under? {code} To enable cross-origin support (CORS) for the Timeline Service v.2, please set the following configuration parameters: In core-site.xml, add org.apache.hadoop.security.HttpCrossOriginFilterInitializer to hadoop.http.filter.initializers. In yarn-site.xml, set yarn.timeline-service.http-cross-origin.enabled to true. For other configurations used for cross-origin support, refer to [HttpAuthentication](../../hadoop-project-dist/hadoop-common/HttpAuthentication.html#CORS). Please note that for timeline service, configuration property, hadoop.http.cross-origin.enabled is not used. {code} Also yarn.timeline-service.http-cross-origin.enabled is not present in yarn-default.xml from before. Should it be there? > CORS support in timeline v2 > --------------------------- > > Key: YARN-6069 > URL: https://issues.apache.org/jira/browse/YARN-6069 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelinereader > Reporter: Sreenath Somarajapuram > Assignee: Rohith Sharma K S > Attachments: YARN-6069-YARN-5355.0001.patch, > YARN-6069-YARN-5355.0002.patch, YARN-6069-YARN-5355.0003.patch > > > By default the browser prevents accessing resources from multiple domains. In > most cases the UIs would be loaded form a domain different from that of > timeline server. Hence without CORS support, it would be difficult for the > UIs to load data from timeline v2. > YARN-2277 must provide more info on the implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org