[ 
https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875647#comment-15875647
 ] 

Karthik Kambatla commented on YARN-6175:
----------------------------------------

In FairScheduler.java, do we still need the Resources.max call? 

> Negative vcore for resource needed to preempt
> ---------------------------------------------
>
>                 Key: YARN-6175
>                 URL: https://issues.apache.org/jira/browse/YARN-6175
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.8.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-6175.001.patch, YARN-6175.branch-2.8.002.patch
>
>
> Both old preemption code (2.8 and before) and new preemption code could have 
> negative vcores while calculating resources needed to preempt.
> For old preemption, you can find following messages in RM logs:
> {code}
> Should preempt <memory:2048, vCores:-2> 
> {code}
> The related code is in method {{resourceDeficit()}}. 
> For new preemption code, there are no messages in RM logs, the related code 
> is in method {{fairShareStarvation()}}. 
> The negative value isn't only a display issue, but also may cause missing 
> necessary preemption. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to