[ 
https://issues.apache.org/jira/browse/YARN-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877505#comment-15877505
 ] 

Rohith Sharma K S commented on YARN-6211:
-----------------------------------------

Thanks Bibin for the patch.. One comment
# For both methods in RMAppManager i.e moveApplicationAcrossQueue and 
updateApplicationPriority, pass the RMApp reference which has been validated by 
clientRMService. Do not again get it from context in RMAppManager. It would 
lead to NPE in very corner cases. 
# Use the RMApp reference to get applicationId in synchronized block. See 
updateApplicationTimeout method for reference.  

> Synchronization improvement in move and priority
> ------------------------------------------------
>
>                 Key: YARN-6211
>                 URL: https://issues.apache.org/jira/browse/YARN-6211
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6211.001.patch
>
>
> Application appid is wrongly taken for synchronization



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to