[
https://issues.apache.org/jira/browse/YARN-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879096#comment-15879096
]
ASF GitHub Bot commented on YARN-6194:
--------------------------------------
Github user kambatla commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/196#discussion_r102555178
--- Diff:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/TestDominantResourceFairnessPolicy.java
---
@@ -40,7 +43,10 @@
private Comparator<Schedulable> createComparator(int clusterMem,
int clusterCpu) {
DominantResourceFairnessPolicy policy = new
DominantResourceFairnessPolicy();
- policy.initialize(BuilderUtils.newResource(clusterMem, clusterCpu));
+ FSContext fsContext = mock(FSContext.class);
+ when(fsContext.getClusterResource()).
+ thenReturn(BuilderUtils.newResource(clusterMem, clusterCpu));
--- End diff --
Let us use Resources.create instead of BuilterUtils.newInstance.
> Cluster capacity in SchedulingPolicy is updated only on allocation file reload
> ------------------------------------------------------------------------------
>
> Key: YARN-6194
> URL: https://issues.apache.org/jira/browse/YARN-6194
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
>
> Some of the {{SchedulingPolicy}} methods need cluster capacity which is set
> using {{#initialize}} today. However, {{initialize()}} is called only on
> allocation reload. If nodes are added between reloads, the cluster capacity
> is not considered until the next reload.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
