[
https://issues.apache.org/jira/browse/YARN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omkar Vinit Joshi reassigned YARN-203:
--------------------------------------
Assignee: Omkar Vinit Joshi
> Fixup ResourceLocalizationService
> ----------------------------------
>
> Key: YARN-203
> URL: https://issues.apache.org/jira/browse/YARN-203
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Eli Collins
> Assignee: Omkar Vinit Joshi
>
> The ResourceLocalizationService source isn't confidence inspiring, let's fix
> this up.
> {code}
> // TODO this sucks. Fix it later
> @SuppressWarnings("unchecked") // dispatcher not typed
> LocalizerHeartbeatResponse update(
> List<LocalResourceStatus> remoteResourceStatuses) {
> ..
> // TODO: Synchronization
> ..
> // TODO: Why is this event going directly to the container. Why not
> // the resource itself? What happens to the resource? Is it removed?
> {code}
> {code}
> assert false; // TODO: FIXME assert doesn't help
> // ^ The condition is benign. Tests should fail and it
> // should appear in logs, but it's an internal error
> // that should have no effect on applications
> {code}
> {code}
> // TODO: What to do with appLocalRsrcsTracker?
> {code}
> {code}
> public void addResource(LocalizerResourceRequestEvent request) {
> // TODO handle failures, cancellation, requests by other containers
> {code}
> {code}
> // TODO: decrement reference counts of all resources associated with this
> // app
> {code}
> {code}
> // TODO shutdown, better error handling esp. DU
> {code}
> {code}
> /*
> * Do not retry for now. Once failed is failed!
> * LocalizerResourceRequestEvent request = reqs.remove(0);
> pending.put(queue.submit(new FSDownload(
> lfs, null, conf, publicDirs,
> request.getResource().getRequest(), new Random())),
> request);
> */
> {code}
> Also, PublicLocalizer has a lot of commented out code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
