[
https://issues.apache.org/jira/browse/YARN-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881606#comment-15881606
]
Haibo Chen commented on YARN-6218:
----------------------------------
Thanks for the patch [~miklos.szeg...@cloudera.com]! Took a cursory look at the
patch.
1) In places where sleep() is replaced with waitForNMHeartbeat(), we may want
to update the comments as well since " sleep to let NM's heartbeat to RM and
trigger allocations" no longer makes sense.
2) At line 1015, the code is check container status from NMs, so it does not
need to wait for NM heartbeats to RM.
3) bq. // Wait for fair scheduler update thread
We are synchronously calling update() in the test thread, not waiting for
the update thread. so maybe we can say triggering fair scheduler update?
> TestAMRMClient fails with fair scheduler
> ----------------------------------------
>
> Key: YARN-6218
> URL: https://issues.apache.org/jira/browse/YARN-6218
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Minor
> Attachments: YARN-6218.000.patch
>
>
> We ran into this issue on v2. Allocation does not happen in the specified
> amount of time.
> Error Message
> expected:<2> but was:<0>
> Stacktrace
> java.lang.AssertionError: expected:<2> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.yarn.client.api.impl.TestAMRMClient.testAMRMClientMatchStorage(TestAMRMClient.java:495)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
