[
https://issues.apache.org/jira/browse/YARN-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888728#comment-15888728
]
Subru Krishnan edited comment on YARN-6247 at 2/28/17 7:33 PM:
---------------------------------------------------------------
Thanks [~botong] for the patch. It looks fairly straightforward. I have only
one suggestion; can you clearly call out in {{SubClusterResolver}} interface
(Javadoc) that implementing classes are expected to be thread-safe.
was (Author: subru):
Thanks [~botong] for the patch. It looks fairly straightforward. I have only
one suggestion; can you clearly call out in {{SubClusterResolver}} interface
that implementing classes are expected to be thread-safe.
> Add SubClusterResolver into FederationStateStoreFacade
> ------------------------------------------------------
>
> Key: YARN-6247
> URL: https://issues.apache.org/jira/browse/YARN-6247
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Attachments: YARN-6247-YARN-2915.v1.patch,
> YARN-6247-YARN-2915.v2.patch
>
>
> Add SubClusterResolver into FederationStateStoreFacade. Since the resolver
> might involve some overhead (read file in the background, potentially
> periodically), it is good to put it inside FederationStateStoreFacade
> singleton, so that only one instance will be created.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
