[ 
https://issues.apache.org/jira/browse/YARN-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889309#comment-15889309
 ] 

Miklos Szegedi commented on YARN-4599:
--------------------------------------

Thank you for the patch [~sandflee]. This would be useful for many users.
I have a few questions.
1. CGroupsElasticMemoryResourceHandlerImpl copies lots of code from 
CGroupsMemoryResourceHandlerImpl. Have you considered inheritance to reduce 
redundancy?
2. Is it better to use JNI as in the current patch, or implement the event 
logic in Linux Container Executor?
3. Could you please rebase it? It does not build anymore.

> Set OOM control for memory cgroups
> ----------------------------------
>
>                 Key: YARN-4599
>                 URL: https://issues.apache.org/jira/browse/YARN-4599
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: sandflee
>              Labels: oct16-medium
>         Attachments: yarn-4599-not-so-useful.patch, YARN-4599.sandflee.patch
>
>
> YARN-1856 adds memory cgroups enforcing support. We should also explicitly 
> set OOM control so that containers are not killed as soon as they go over 
> their usage. Today, one could set the swappiness to control this, but 
> clusters with swap turned off exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to