[
https://issues.apache.org/jira/browse/YARN-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-6232:
--------------------------------
Attachment: YARN-6232-YARN-3926.003.patch
Thanks for the review [~leftnoteasy] and [~sunilg]!
Uploaded a new patch with the following fixes -
bq. 1. In getResourceSecondsString, usage of getOrDefault could be avoided as
we may need to back port to branch-2. Similarly in ApplicationAttemptStateData
as well
Fixed.
bq. RMAppManager#createAppSummary has a typo. .add("resourceSeonds",
Fixed.
bq. 1. In RMAppAttemptMetrics, instead of using private Map<String, AtomicLong>
resourceUsageMap = new HashMap<>();, could we use ConcurrentHashMap itself.?
Hmm. I figured it's easier to keep as much of the the existing code as
possible. [~leftnoteasy] - what do you think?
bq. @Deprecated methods can be removed from following unstable classes:
Fixed.
bq. Changes of ResourceInfo: are they compatible? I'm fine with these changes
if they're compatible changes.
Yes. They are compatible changes.
bq. ApplicationResourceUsageMapProto: Is it better to rename it to
StringLongMapProto
Fixed.
> Update resource usage and preempted resource calculations to take into
> account all resource types
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-6232
> URL: https://issues.apache.org/jira/browse/YARN-6232
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-6232-YARN-3926.001.patch,
> YARN-6232-YARN-3926.002.patch, YARN-6232-YARN-3926.003.patch
>
>
> The chargeback calculations that take place on the RM should be updated to
> take all resource types into account.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
