[
https://issues.apache.org/jira/browse/YARN-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892826#comment-15892826
]
Jian He commented on YARN-6153:
-------------------------------
[~kyungwan nam], thanks for investigation. I missed this. instead of changing
it back to hard coded sleep, we should continue to use system clock.
Hard-coded sleep is bad because it prolongs the test's execution and also
sometimes indeterministic.
So let's revert the change of moving this code to RMAppAttempt, so that we can
continue to use system clock.
{code}
- if (this.attemptFailuresValidityInterval <= 0
- || (attempt.getFinishTime() > endTime
- - this.attemptFailuresValidityInterval)) {
- completedAttempts++;
- }
+ com
{code}
> keepContainer does not work when AM retry window is set
> -------------------------------------------------------
>
> Key: YARN-6153
> URL: https://issues.apache.org/jira/browse/YARN-6153
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.1
> Reporter: kyungwan nam
> Assignee: kyungwan nam
> Fix For: 2.8.0, 3.0.0-alpha3
>
> Attachments: YARN-6153.001.patch, YARN-6153.002.patch,
> YARN-6153.003.patch, YARN-6153.004.patch, YARN-6153.005.patch,
> YARN-6153.006-1.patch, YARN-6153.006.patch, YARN-6153-branch-2.8.patch
>
>
> yarn.resourcemanager.am.max-attempts has been configured to 2 in my cluster.
> I submitted a YARN application (slider app) that keepContainers=true,
> attemptFailuresValidityInterval=300000.
> it did work properly when AM was failed firstly.
> all containers launched by previous AM were resynced with new AM (attempt2)
> without killing containers.
> after 10 minutes, I thought AM failure count was reset by
> attemptFailuresValidityInterval (5 minutes).
> but, all containers were killed when AM was failed secondly. (new AM attempt3
> was launched properly)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
