[
https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892935#comment-15892935
]
Sangjin Lee edited comment on YARN-6256 at 3/2/17 8:35 PM:
-----------------------------------------------------------
Thanks for the patch [~rohithsharma]! I took a quick look at it, and I still
need to do a more thorough review, but my observations so far are similar to
Varun's above.
I do have another question (which also applies to YARN-6027). It seems that
we're embedding the FROMID value for every single entity we return. Would it be
possible to do this only for the "last" entity that gets returned if we're
returning multiple entities? This might be a secondary optimization, but for
all other entities but the last, the FROMID value would be ignored. In that
sense, it would simply add to the payload size without providing benefits.
Thoughts?
was (Author: sjlee0):
Thanks for the patch [~rohithsharma]! I took a quick look at it, and I still
need to do a more thorough review, but my observations so far are similar to
Varun's above.
I do have another questions (which also applies to YARN-6027). It seems that
we're embedding the FROMID value for every single entity we return. Would it be
possible to do this only for the "last" entity that gets returned if we're
returning multiple entities? This might be a secondary optimization, but for
all other entities but the last, the FROMID value would be ignored. In that
sense, it would simply add to the payload size without providing benefits.
Thoughts?
> Add FROM_ID info key for timeline entities in reader response.
> ---------------------------------------------------------------
>
> Key: YARN-6256
> URL: https://issues.apache.org/jira/browse/YARN-6256
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6256-YARN-5355.0001.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline
> entity responses which includes
> # Flow run entity response.
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix
> filter which is now separately provided.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
