[ 
https://issues.apache.org/jira/browse/YARN-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704730#comment-13704730
 ] 

Vinod Kumar Vavilapalli commented on YARN-649:
----------------------------------------------

bq. for the new HTTP service returning logs, a 64K buffer is used to stream the 
logs, so there things are bounded.
Interesting, this is in common?

bq. For the existing web ui page that display the logs, that is a different 
story, the current implementation is loading the complete log in memory, 
creating the page, and returning it. The later should be fix to do streaming 
similar to the new HTTP plain/text, but that is another JIRA (just created 
YARN-911)
I checked this before itself, we aren't loading it in memory. I see this 
"pre._(new String(cbuf, 0, len));" which eventually is doing a println, and 
depending on the HttpServer buffer size, it will be flushed sometime. Is that 
correct?

bq. Are we good then with the latest patch here?
No. I pointed out atleast one possible bug and few nits that still need to be 
fixed.
                
> Make container logs available over HTTP in plain text
> -----------------------------------------------------
>
>                 Key: YARN-649
>                 URL: https://issues.apache.org/jira/browse/YARN-649
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-649-2.patch, YARN-649-3.patch, YARN-649-4.patch, 
> YARN-649-5.patch, YARN-649.patch, YARN-752-1.patch
>
>
> It would be good to make container logs available over the REST API for 
> MAPREDUCE-4362 and so that they can be accessed programatically in general.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to