[
https://issues.apache.org/jira/browse/YARN-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900373#comment-15900373
]
Xuan Gong commented on YARN-5948:
---------------------------------
Thanks for the patch. [~jonathan_huang]
Overall looks good.
One nit:
instead of using:
{code}
public static final String SCHEDULER_CONFIGURATION_STORE = YARN_PREFIX +
"scheduler.configuration.store";
public static final String MEMORY_CONFIGURATION_STORE = "memory";
{code}
Could you using the configuration, such as SCHEDULER_CONFIGURATION_STORE_CLASS
? And create a SCHEDULER_CONFIGURATION_STORE factory to load it.
This is the example on how we load the RMStateStore class.
{code}
public static RMStateStore getStore(Configuration conf) {
Class<? extends RMStateStore> storeClass =
conf.getClass(YarnConfiguration.RM_STORE,
MemoryRMStateStore.class, RMStateStore.class);
LOG.info("Using RMStateStore implementation - " + storeClass);
return ReflectionUtils.newInstance(storeClass, conf);
}
{code}
> Implement MutableConfigurationManager for handling storage into configuration
> store
> -----------------------------------------------------------------------------------
>
> Key: YARN-5948
> URL: https://issues.apache.org/jira/browse/YARN-5948
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Attachments: YARN-5948.001.patch, YARN-5948-YARN-5734.002.patch,
> YARN-5948-YARN-5734.003.patch, YARN-5948-YARN-5734.004.patch,
> YARN-5948-YARN-5734.005.patch
>
>
> The MutableConfigurationManager will take REST calls with desired client
> configuration changes and call YarnConfigurationStore methods to store these
> changes in the backing store.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
