[ 
https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902184#comment-15902184
 ] 

Haibo Chen commented on YARN-6288:
----------------------------------

[~ajisakaa] Have you considered making LogWriter closable so that try clause 
can auto-close it?

> Refactor AppLogAggregatorImpl#uploadLogsForContainers
> -----------------------------------------------------
>
>                 Key: YARN-6288
>                 URL: https://issues.apache.org/jira/browse/YARN-6288
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>            Priority: Minor
>              Labels: supportability
>         Attachments: YARN-6288.01.patch
>
>
> In AppLogAggregatorImpl.java, if an exception occurs in writing container log 
> to remote filesystem, the exception is not caught and ignored.
> https://github.com/apache/hadoop/blob/f59e36b4ce71d3019ab91b136b6d7646316954e7/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java#L398



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to