[
https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903972#comment-15903972
]
Haibo Chen commented on YARN-5269:
----------------------------------
On the client side, putEntities() is a blocking call and putEntitiesAsync is a
fire-and-forget operation. For each rest request, we check the response code
from the server and wrap them in a generic YarnException.
On the server side(TimelineCollectorWebService), even though clients can
specify an async flag, this flag is always omitted for the time being.
Therefore, the guarantees are the same as those provided by
HBaseTimelineWriter.write(). IIUC, because BufferedMutator is totally async,
HBaseTimelineWriter.write() does not guarantee anything to clients. Is that
correct [~vrushalic]? As I think about this more, it seems that the sync
putEntities() only ensures that entities are added to the buffer in
bufferedMutator without any problem. How would this change with respect to
SpooledBufferedMutator, [~vrushalic], [~jrottinghuis]?
> Bubble exceptions and errors all the way up the calls, including to clients.
> ----------------------------------------------------------------------------
>
> Key: YARN-5269
> URL: https://issues.apache.org/jira/browse/YARN-5269
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Joep Rottinghuis
> Assignee: Haibo Chen
> Labels: YARN-5355, yarn-5355-merge-blocker
>
> Currently we ignore (swallow) exception from the HBase side in many cases
> (reads and writes).
> Also, on the client side, neither TimelineClient#putEntities (the v2 flavor)
> nor the #putEntitiesAsync method return any value.
> For the second drop we may want to consider how we properly bubble up
> exceptions throughout the write and reader call paths and if we want to
> return a response in putEntities and some future kind of result for
> putEntitiesAsync.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
