[ 
https://issues.apache.org/jira/browse/YARN-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904329#comment-15904329
 ] 

Yuanbo Liu commented on YARN-6300:
----------------------------------

[~templedf] Thanks for your commit
!Selection_124.png!
I've seen this patch in branch-2, so I guess I don't need to provide branch-2 
patch any more, right?

> NULL_UPDATE_REQUESTS is redundant in TestFairScheduler
> ------------------------------------------------------
>
>                 Key: YARN-6300
>                 URL: https://issues.apache.org/jira/browse/YARN-6300
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Daniel Templeton
>            Assignee: Yuanbo Liu
>            Priority: Minor
>              Labels: newbie
>             Fix For: 3.0.0-alpha3
>
>         Attachments: Selection_124.png, YARN-6300.001.patch
>
>
> The {{TestFairScheduler.NULL_UPDATE_REQUESTS}} field hides 
> {{FairSchedulerTestBase.NULL_UPDATE_REQUESTS}}, which has the same value.  
> The {{NULL_UPDATE_REQUESTS}} field should be removed from 
> {{TestFairScheduler}}.
> While you're at it, maybe also remove the unused import.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to