[ https://issues.apache.org/jira/browse/YARN-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925133#comment-15925133 ]
Haibo Chen commented on YARN-6334: ---------------------------------- Thanks for the fix, [~yufeigu]! Can we extract a new method that does the checking instead of having two copies? Otherwise, it looks good to me. > TestRMFailover#testAutomaticFailover always passes even RM didn't transition > to Standby. > ---------------------------------------------------------------------------------------- > > Key: YARN-6334 > URL: https://issues.apache.org/jira/browse/YARN-6334 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6334.001.patch > > > Due to a bug in {{while}} loop. > {code} > int maxWaitingAttempts = 2000; > while (maxWaitingAttempts-- > 0 ) { > if (rm.getRMContext().getHAServiceState() == HAServiceState.STANDBY) { > break; > } > Thread.sleep(1); > } > Assert.assertFalse("RM didn't transition to Standby ", > maxWaitingAttempts == 0); > {code} > maxWaitingAttempts is -1 if RM didn't transition to Standby. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org