[ 
https://issues.apache.org/jira/browse/YARN-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930346#comment-15930346
 ] 

Jason Lowe commented on YARN-6217:
----------------------------------

I tend to agree.  Originally there was an edict to put a timeout on each test 
because the build wasn't doing a good job of handling tests that timed out.  
However that has since been fixed.  An explicit test timeout still makes a lot 
of sense when the test has a good chance of deadlocking when broken (e.g.: 
needing to carefully synchronize a number of threads, wait for barriers, doing 
a polling loop, etc.), but I don't think that's the case with the tests here.

> TestLocalCacheDirectoryManager test timeout is too aggressive
> -------------------------------------------------------------
>
>                 Key: YARN-6217
>                 URL: https://issues.apache.org/jira/browse/YARN-6217
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Jason Lowe
>            Assignee: Miklos Szegedi
>         Attachments: YARN-6217.000.patch
>
>
> TestLocalCacheDirectoryManager#testDirectoryStateChangeFromFullToNonFull has 
> only a one second timeout.  If the test machine hits an I/O hiccup it can 
> fail.  The test timeout is too aggressive, and I question whether this test 
> even needs an explicit timeout specified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to