[ 
https://issues.apache.org/jira/browse/YARN-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Kanter updated YARN-6359:
--------------------------------
    Attachment: YARN-6359.002.patch

Thanks for the review.

Oops, I totally missed that the test has a 60sec timeout.  And I had thought 
there was a {{waitFor}} somewhere, but couldn't find it for some reason so I 
went and did this.  I didn't think we needed to check the timeout after the 
loop because we check the metric, which would have failed if it was wrong 
anyway.

In any case, the 002 patch addresses the timeout and the {{waitFor}}.  

> TestRM#testApplicationKillAtAcceptedState fails rarely due to race condition
> ----------------------------------------------------------------------------
>
>                 Key: YARN-6359
>                 URL: https://issues.apache.org/jira/browse/YARN-6359
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.9.0, 3.0.0-alpha3
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: YARN-6359.001.patch, YARN-6359.002.patch
>
>
> We've seen (very rarely) a test failure in 
> {{TestRM#testApplicationKillAtAcceptedState}}
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<0>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at org.junit.Assert.assertEquals(Assert.java:542)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.TestRM.testApplicationKillAtAcceptedState(TestRM.java:645)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to