[
https://issues.apache.org/jira/browse/YARN-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706273#comment-13706273
]
Sandy Ryza commented on YARN-912:
---------------------------------
Does it really make sense to put exceptions in their own package? Is their any
precedent for this in other well known Java libraries? It seems to me that we
should just put these in the package that is likely to throw them, i.e.
org.apache.hadoop.yarn.client.api.
A couple documentation nits:
{code}
- * requested memory/vcore is non-negative and not greater than max
+ * requested memory/vcore is non-negative and not greater than max throws
+ * exception <code>InvalidResourceRequestException</code> when there is
+ * invalid request
{code}
"throws" should be on a separate line as "@throws"
{code}
+ /*
+ * This method will throw <code>InvalidResourceBlacklistRequestException
+ * </code> If the resource is not be able to add to black list.
+ */
{code}
"If the resource is not be able to add to black list." should be "if the
resource is not able to be added to the blacklist."
> Create exceptions package in common/api for yarn and move client facing
> exceptions to them
> ------------------------------------------------------------------------------------------
>
> Key: YARN-912
> URL: https://issues.apache.org/jira/browse/YARN-912
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.1.0-beta
> Reporter: Bikas Saha
> Assignee: Mayank Bansal
> Attachments: YARN-912-trunk-1.patch
>
>
> Exceptions like InvalidResourceBlacklistRequestException,
> InvalidResourceRequestException, InvalidApplicationMasterRequestException etc
> are currently inside ResourceManager and not visible to clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
