[
https://issues.apache.org/jira/browse/YARN-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933627#comment-15933627
]
Daniel Templeton commented on YARN-6334:
----------------------------------------
I'm not a fan of wonky _for_ statements. Wanna replace that _for-if_ with a
_while_ and a decrement?
> TestRMFailover#testAutomaticFailover always passes even when it should fail
> ---------------------------------------------------------------------------
>
> Key: YARN-6334
> URL: https://issues.apache.org/jira/browse/YARN-6334
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-6334.001.patch, YARN-6334.002.patch,
> YARN-6334.003.patch, YARN-6334.004.patch
>
>
> Due to a bug in {{while}} loop.
> {code}
> int maxWaitingAttempts = 2000;
> while (maxWaitingAttempts-- > 0 ) {
> if (rm.getRMContext().getHAServiceState() == HAServiceState.STANDBY) {
> break;
> }
> Thread.sleep(1);
> }
> Assert.assertFalse("RM didn't transition to Standby ",
> maxWaitingAttempts == 0);
> {code}
> maxWaitingAttempts is -1 if RM didn't transition to Standby.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
