[
https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935313#comment-15935313
]
Varun Saxena edited comment on YARN-6342 at 3/21/17 8:53 PM:
-------------------------------------------------------------
[~haibochen], correct. FutureTask#run won't throw any exception.
How about fixing the other issue which I pointed out?
While stopping NM Timeline Publisher i.e. in NMTimelinePublisher#serviceStop we
are not explicitly stopping app related timeline clients which would mean that
some of the entities lying around in the queue may not be written to
collector...
Thoughts?
was (Author: varun_saxena):
[~haibochen], correct. FutureTask#run won't throw any exception.
How about fixing the other issue which I pointed out?
While stopping i.e. in NMTimelinePublisher#serviceStop we are not explicitly
stopping app related timeline clients which would mean that some of the
entities lying around in the queue may not be written...
Thoughts?
> Issues in async API of TimelineClient
> -------------------------------------
>
> Key: YARN-6342
> URL: https://issues.apache.org/jira/browse/YARN-6342
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Haibo Chen
> Labels: yarn-5355-merge-blocker
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should
> it use shutdown instead ?
> {code}
> public void stop() {
> LOG.info("Stopping TimelineClient.");
> executor.shutdownNow();
> try {
> executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
> } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity
> (publishWithoutBlockingOnQueue), the thread exists. I think it should try
> best effort to continue publishing the timeline entities, one failure should
> not cause all followup entities not published.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
