[
https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937223#comment-15937223
]
Varun Saxena edited comment on YARN-5269 at 3/22/17 9:54 PM:
-------------------------------------------------------------
We had actually discussed about TimelinePutResponse long before.
I think where we thought TimelinePutResponse will be useful is that in
HBaseTimelineWriterImpl#write we write entities one by one. And it maybe
possible that a set of writes are successful and another set is not.
But frankly writes are not persisted till flush is called, if buffer size is
not exceeded.
Should we attempt a flush for sync put even if an exception occurs on write.
Can a flush succeed in such a scenario?
cc [~vrushalic]
was (Author: varun_saxena):
We had actually discussed about TimelinePutResponse long before.
I think where we though TimelinePutResponse will be useful is that in
HBaseTimelineWriterImpl#write we write entities one by one. And it maybe
possible that a set of writes are successful and another set is not.
But frankly writes are not persisted till flush is called, if buffer size is
not exceeded.
Should we attempt a flush for sync put even if an exception occurs on write.
Can a flush succeed in such a scenario?
cc [~vrushalic]
> Bubble exceptions and errors all the way up the calls, including to clients.
> ----------------------------------------------------------------------------
>
> Key: YARN-5269
> URL: https://issues.apache.org/jira/browse/YARN-5269
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Joep Rottinghuis
> Assignee: Haibo Chen
> Labels: YARN-5355, yarn-5355-merge-blocker
>
> Currently we ignore (swallow) exception from the HBase side in many cases
> (reads and writes).
> Also, on the client side, neither TimelineClient#putEntities (the v2 flavor)
> nor the #putEntitiesAsync method return any value.
> For the second drop we may want to consider how we properly bubble up
> exceptions throughout the write and reader call paths and if we want to
> return a response in putEntities and some future kind of result for
> putEntitiesAsync.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
