[
https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939383#comment-15939383
]
ASF GitHub Bot commented on YARN-5829:
--------------------------------------
Github user kambatla commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/201#discussion_r107802366
--- Diff:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
---
@@ -987,9 +978,19 @@ void attemptScheduling(FSSchedulerNode node) {
}
// Assign new containers...
- // 1. Check for reserved applications
- // 2. Schedule if there are no reservations
-
+ // 1. Ensure containers are assigned to the apps that preempted
+ // 2. Check for reserved applications
+ // 3. Schedule if there are no reservations
+
+ // Apps may wait for preempted containers
+ // We have to satisfy these first to avoid cases, when we preempt
+ // a container for A from B and C gets the preempted containers,
+ // when C does not qualify for preemption itself.
+ for (FSAppAttempt app : node.getPreemptionList()) {
--- End diff --
Also, we are not counting allocated resources/containers against the
assignMultiple. We probably should so that we limit the number of
non-preemption, non-reserved containers/resources appropriately.
> FS preemption should reserve a node before considering containers on it for
> preemption
> --------------------------------------------------------------------------------------
>
> Key: YARN-5829
> URL: https://issues.apache.org/jira/browse/YARN-5829
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Miklos Szegedi
>
> FS preemption evaluates nodes for preemption, and subsequently preempts
> identified containers. If this node is not reserved for a specific
> application, any other application could be allocated resources on this node.
> Reserving the node for the starved application before preempting containers
> would help avoid this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
