[ https://issues.apache.org/jira/browse/YARN-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941122#comment-15941122 ]
Karthik Kambatla commented on YARN-5685: ---------------------------------------- Have no recollection from my previous review. Looked through again. Minor comments: # In the javadoc for {{verifyLeaderElection}}, the @link annotation is missing the closing brace. # In TestRMAdminService, can we split the three cases in the test to three individual tests. > Non-embedded HA failover is broken > ---------------------------------- > > Key: YARN-5685 > URL: https://issues.apache.org/jira/browse/YARN-5685 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.9.0, 3.0.0-alpha1 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Priority: Critical > Labels: oct16-hard > Attachments: YARN-5685.001.patch, YARN-5685.002.patch, > YARN-5685.003.patch, YARN-5685.004.patch > > > If HA is enabled with automatic failover enabled and embedded failover > disabled, all RMs all come up in standby state. To make one of them active, > the {{\-\-forcemanual}} flag must be used when manually triggering the state > change. Should the active go down, the standby will not become active and > must be manually transitioned with the {{\-\-forcemanual}} flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org