[
https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947892#comment-15947892
]
Varun Saxena commented on YARN-6342:
------------------------------------
Thanks [~haibochen] for the patch.
It looks good to me in general.
I have a few comments on the config though.
# I think the configuration should start with
{{yarn.timeline-service.client.}}. You can use TIMELINE_SERVICE_CLIENT_PREFIX
instead of TIMELINE_SERVICE_PREFIX in YarnConfiguration.
# How about naming the configuration
{{yarn.timeline-service.client.drain-entities.timeout.ms}}. I think the
configuration description can tell that its done on stop.
# We need to add this configuration in yarn-default.xml
> Make TimelineV2Client's drain period after stop configurable
> ------------------------------------------------------------
>
> Key: YARN-6342
> URL: https://issues.apache.org/jira/browse/YARN-6342
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Haibo Chen
> Attachments: YARN-6342.00.patch
>
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should
> it use shutdown instead ?
> {code}
> public void stop() {
> LOG.info("Stopping TimelineClient.");
> executor.shutdownNow();
> try {
> executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
> } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity
> (publishWithoutBlockingOnQueue), the thread exists. I think it should try
> best effort to continue publishing the timeline entities, one failure should
> not cause all followup entities not published.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
