[ 
https://issues.apache.org/jira/browse/YARN-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953360#comment-15953360
 ] 

Varun Saxena commented on YARN-6428:
------------------------------------

Thanks [~bibinchundatt] for the patch.
The said issue due to conversion does exist.

So it does make sense to have a float version of the method in 
ResourceCalculator to avoid such issues due to conversion. 
We can alternatively strip off the extraneous decimal digits too but that would 
not be as straightforward.
And in this case, as ResourceCalculator is annotated as Private, we can add an 
abstract method to it as well.

However, it seems the values passed to 
ResourceCalculator#multiplyAndNormalizeUp are all in float. But as double has 
larger range and more precision, it might be better, in general as a data type, 
when we do calculations in scheduler.
So can't we alternatively read these configurations as double too? Thoughts?

> Queue AM limit is not honored  in CS always
> -------------------------------------------
>
>                 Key: YARN-6428
>                 URL: https://issues.apache.org/jira/browse/YARN-6428
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6428.0001.patch
>
>
> Steps to reproduce
> ------------------------
> Setup cluster with 40 GB and 40 vcores with 4 Node managers with 10 GB each.
> Configure 100% to default queue as capacity and max am limit as 10 %
> Minimum scheduler memory and vcore as 512,1
> *Expected* 
> AM limit 4096 and 4 vores
> *Actual*
> AM limit 4096+512 and 4+1 vcore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to