[
https://issues.apache.org/jira/browse/YARN-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953990#comment-15953990
]
Vrushali C commented on YARN-6424:
----------------------------------
Thanks [~varun_saxena]. No, we don't need to make more changes. Let's keep the
patch as you have it. It looks like ApplicationFinishPublishEvent is being
published and handled by TimelineV2 only, V1 does not seem to have it.
bq. We may also want to specify SystemMetricsEventType.PUBLISH_ENTITY in
ApplicationFinishPublishEvent constructor if that is the only possible type.
I think SystemMetricsEventType does have two types PUBLISH_ENTITY and
PUBLISH_APPLICATION_FINISHED_ENTITY , so the current patch should be good.
+1 LGTM.
> TimelineCollector is not stopped when an app finishes in RM
> -----------------------------------------------------------
>
> Key: YARN-6424
> URL: https://issues.apache.org/jira/browse/YARN-6424
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: 3.0.0-alpha2
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Priority: Critical
> Attachments: YARN-6424.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
