[
https://issues.apache.org/jira/browse/YARN-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708169#comment-13708169
]
Bikas Saha commented on YARN-513:
---------------------------------
ClientRMProxy.createRMProxy doesnt even take 3 arguments. There should be no
rmAddress passed to it.
{code}
+ try {
+ rmClient = ClientRMProxy.createRMProxy(getConfig(),
+ ApplicationClientProtocol.class, rmAddress);
+ } catch (IOException e) {
+ throw new YarnRuntimeException(e);
{code}
bq. These two methods are separate as one for ResourceTrackerPB.class,the other
for ResourceTracker.class. we can also see this from YarnClientImpl.serviceStop
and ApplicationClientProtocolPBClientImpl.close(). Did not investigate into the
deep implementations.
No one is calling the close() method? Unless there is someplace that calls
close() automatically. Why did we need to add it in this patch?
> Create common proxy client for communicating with RM
> ----------------------------------------------------
>
> Key: YARN-513
> URL: https://issues.apache.org/jira/browse/YARN-513
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Bikas Saha
> Assignee: Jian He
> Attachments: YARN-513.10.patch, YARN-513.11.patch, YARN-513.12.patch,
> YARN-513.13.patch, YARN-513.14.patch, YARN-513.1.patch, YARN-513.2.patch,
> YARN-513.3.patch, YARN-513.4.patch, YARN.513.5.patch, YARN-513.6.patch,
> YARN-513.7.patch, YARN-513.8.patch, YARN-513.9.patch
>
>
> When the RM is restarting, the NM, AM and Clients should wait for some time
> for the RM to come back up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira