[
https://issues.apache.org/jira/browse/YARN-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955816#comment-15955816
]
Hadoop QA commented on YARN-6430:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} hadoop-tools/hadoop-sls: The patch generated 7
new + 77 unchanged - 1 fixed = 84 total (was 78) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} hadoop-tools/hadoop-sls generated 5 new + 0 unchanged
- 0 fixed = 5 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
29s{color} | {color:green} hadoop-sls in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
18s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-sls |
| | org.apache.hadoop.yarn.sls.SLSRunner.simulateInfoMap isn't final and
can't be protected from malicious code At SLSRunner.java:be protected from
malicious code At SLSRunner.java:[line 114] |
| | org.apache.hadoop.yarn.sls.SLSRunner.inUnitTest isn't final but should be
At SLSRunner.java:be At SLSRunner.java:[line 115] |
| | Write to static field org.apache.hadoop.yarn.sls.SLSRunner.remainingApps
from instance method new org.apache.hadoop.yarn.sls.SLSRunner(boolean,
String[], String, String, Set, boolean) At SLSRunner.java:from instance method
new org.apache.hadoop.yarn.sls.SLSRunner(boolean, String[], String, String,
Set, boolean) At SLSRunner.java:[line 124] |
| | Write to static field
org.apache.hadoop.yarn.sls.SLSRunner.simulateInfoMap from instance method new
org.apache.hadoop.yarn.sls.SLSRunner(boolean, String[], String, String, Set,
boolean) At SLSRunner.java:from instance method new
org.apache.hadoop.yarn.sls.SLSRunner(boolean, String[], String, String, Set,
boolean) At SLSRunner.java:[line 123] |
| | Write to static field org.apache.hadoop.yarn.sls.SLSRunner.taskRunner
from instance method new org.apache.hadoop.yarn.sls.SLSRunner(boolean,
String[], String, String, Set, boolean) At SLSRunner.java:from instance method
new org.apache.hadoop.yarn.sls.SLSRunner(boolean, String[], String, String,
Set, boolean) At SLSRunner.java:[line 122] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-6430 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12861952/YARN-6430.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux ca7a7ec807f3 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 1843213 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/15511/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/15511/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-sls.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/15511/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-YARN-Build/15511/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/15511/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Better unit test coverage required for SLS
> ------------------------------------------
>
> Key: YARN-6430
> URL: https://issues.apache.org/jira/browse/YARN-6430
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler-load-simulator
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6430.001.patch
>
>
> Now SLS has very limited unit test coverages. We need add more to make sure
> new changes will not likely cause regression.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
