[
https://issues.apache.org/jira/browse/YARN-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956103#comment-15956103
]
Chris Trezzo commented on YARN-6004:
------------------------------------
These unit tests fail locally on branch-2 without the patch. As far as I can
tell these failures are unrelated. The patches should be good to go for trunk
and branch-2.
> Refactor TestResourceLocalizationService#testDownloadingResourcesOnContainer
> so that it is less than 150 lines
> --------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6004
> URL: https://issues.apache.org/jira/browse/YARN-6004
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Trivial
> Labels: newbie
> Attachments: YARN-6004-branch-2.001.patch, YARN-6004-trunk.001.patch,
> YARN-6004-trunk.002.patch
>
>
> The TestResourceLocalizationService#testDownloadingResourcesOnContainerKill
> method is over 150 lines:
> bq.
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/TestResourceLocalizationService.java:1128:
> @Test(timeout = 20000):3: Method length is 242 lines (max allowed is 150).
> This method needs to be refactored and broken up into smaller methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
