[
https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957458#comment-15957458
]
Vinod Kumar Vavilapalli commented on YARN-5366:
-----------------------------------------------
bq. While it is possible to do a docker kill --signal SIGQUIT this is limited
in it usefulness and may result in unexpected behavior. The signal is always
sent to PID 1 in the container. Depending on the image or app type, this may
not be the process we want to catch that signal. Alternatively, users can
specify the STOPSIGNAL in the Dockerfile and the user likely has a better
understanding of the implications for that application/image type. Thoughts on
how this should be handled? Should we just ignore the Signal.QUIT?
This is kind of the same expectation in the non-docker case where there is a
process-tree and the signal is simply just delivered without the NM
interpreting it. I think we should just pass any signal that is not 0, KILL and
TERM along to the container via "docker kill -s ".
bq. IMO, moving more of this logic into c-e complicates matters and doesn't
follow what we've done so far. Nearly all existing DockerCommands execute via
c-e as a single Docker CLI command.
It's a performance optimization. We can come back to this later if it indeed
becomes a bottleneck.
> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
> Key: YARN-5366
> URL: https://issues.apache.org/jira/browse/YARN-5366
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Labels: oct16-medium
> Attachments: YARN-5366.001.patch, YARN-5366.002.patch,
> YARN-5366.003.patch, YARN-5366.004.patch, YARN-5366.005.patch,
> YARN-5366.006.patch
>
>
> Currently, completed and failed docker containers are removed by
> container-executor. Add a job level environment variable to
> DockerLinuxContainerRuntime to allow the user to toggle whether they want the
> container deleted or not and remove the logic from container-executor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
