[ 
https://issues.apache.org/jira/browse/YARN-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960068#comment-15960068
 ] 

Robert Kanter commented on YARN-6368:
-------------------------------------

You're right.  My environment wasn't cleaned properly.  The test passes now.

However, the code doesn't compile on branch-2:
{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on 
project hadoop-yarn-server-nodemanager: Compilation failure
[ERROR] 
/Users/rkanter/dev/hadoop-git/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java:[440,32]
 local variable exitCode is accessed from within inner class; needs to be 
declared final
{noformat}
That actually makes sense, but seems strange that this isn't a problem in trunk.


> Decommissioning an NM results in a -1 exit code
> -----------------------------------------------
>
>                 Key: YARN-6368
>                 URL: https://issues.apache.org/jira/browse/YARN-6368
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>         Attachments: YARN-6368.000.patch, YARN-6368.001.patch, 
> YARN-6368.002.patch, YARN-6368.003.patch
>
>
> In NodeManager.java we should exit normally in case the RM shuts down the 
> node:
> {code}
>         } finally {
>           if (shouldExitOnShutdownEvent
>               && !ShutdownHookManager.get().isShutdownInProgress()) {
>             ExitUtil.terminate(-1);
>           }
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to