[ 
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961027#comment-15961027
 ] 

Daniel Templeton commented on YARN-2962:
----------------------------------------

A couple of quick questions:

# Why are you removing the {{rm1.close()}} and {{rm2.close()}} in 
{{TestZKRMStateStore.testFencing()}}?
# Why drop this log line {{LOG.info("Unknown child node with name: " + 
childNodeName);}} in {{loadRMAppState()}}

Also, two super minor quibbles:

{code}
  private static RMApp createMockAppForRemove(ApplicationId appId,
      ApplicationAttemptId...attemptIds) {
{code} should have a space after the ellipses.

In {{yarn-default.xml}}, the first line should have a space before the 
parenthesis.

If you don't mind posting a patch to fix the spaces, that would be great.  If 
not, I'll file a couple newbie JIRAs to fix them post-commit.

> ZKRMStateStore: Limit the number of znodes under a znode
> --------------------------------------------------------
>
>                 Key: YARN-2962
>                 URL: https://issues.apache.org/jira/browse/YARN-2962
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Varun Saxena
>            Priority: Critical
>         Attachments: YARN-2962.006.patch, YARN-2962.007.patch, 
> YARN-2962.008.patch, YARN-2962.008.patch, YARN-2962.009.patch, 
> YARN-2962.010.patch, YARN-2962.01.patch, YARN-2962.04.patch, 
> YARN-2962.05.patch, YARN-2962.2.patch, YARN-2962.3.patch
>
>
> We ran into this issue where we were hitting the default ZK server message 
> size configs, primarily because the message had too many znodes even though 
> they individually they were all small.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to