[
https://issues.apache.org/jira/browse/YARN-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966160#comment-15966160
]
Carlo Curino commented on YARN-6282:
------------------------------------
[~botong] thanks for the patch, few questions:
# while not very likely (required concurrent invocations of this object
back-to-back) *chainWrapperBackup.getApplicationId()* could be null (as the
wrapper is initialized after and not under the same synchronization), probably
best check for that to avoid an NPE.
# in case things "go wrong" do we have any safe behavior to put in a *finally*
block to ensure we leave things tidy.
> Recreate interceptor chain for different attemptId in the same node in
> AMRMProxy
> --------------------------------------------------------------------------------
>
> Key: YARN-6282
> URL: https://issues.apache.org/jira/browse/YARN-6282
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Attachments: YARN-6282.v1.patch, YARN-6282.v2.patch,
> YARN-6282.v3.patch
>
>
> In AMRMProxy, an interceptor chain is created per application attempt. But
> the pipeline mapping uses application Id as key. So when a different attempt
> comes in the same node, we need to recreate the interceptor chain for it,
> instead of using the existing one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
