[ 
https://issues.apache.org/jira/browse/YARN-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709388#comment-13709388
 ] 

Omkar Vinit Joshi commented on YARN-62:
---------------------------------------

thanks vinod..
bq. Though it works in most cases, it isn't logically correct to expire old 
token only if a new container comes in or succeeds. We should perform the 
expiry in a thread.

I thought about threads earlier but that is like starting an additional one to 
maintain this and seems like an overhead. thoughts?

bq. Can you also write a specific test which launches a container that very 
quickly exits, turns around and launches another container with same ID and 
token and gets rejected?
bq. Also, please write a test which makes sure that old tokens are expired 
after 10 mins.
yeah will add one...

                
> AM should not be able to abuse container tokens for repetitive container 
> launches
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-62
>                 URL: https://issues.apache.org/jira/browse/YARN-62
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Omkar Vinit Joshi
>         Attachments: YARN-62-20130621.1.patch, YARN-62-20130621.patch, 
> YARN-62-20130628.patch
>
>
> Clone of YARN-51.
> ApplicationMaster should not be able to store container tokens and use the 
> same set of tokens for repetitive container launches. The possibility of such 
> abuse is there in the current code, for a duration of 1d+10mins, we need to 
> fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to