[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974367#comment-15974367
]
Sunil G commented on YARN-6445:
-------------------------------
Thanks [~vvasudev]
Generally changes are fine. Few more nits.
# In *UnitsConversionUtil#convert*, overflowMsg could be local wherever we
throw exception. i think we could save a string object there.
# While looking through *ResourcePBImpl#getResources*, it seems we are not
returning an unmodifiable map. There may be chance now to delete key from this
map by the caller.
# *ResourceInformation#copy*. we could add java doc for better clarity.
> Improve YARN-3926 performance with respect to SLS
> -------------------------------------------------
>
> Key: YARN-6445
> URL: https://issues.apache.org/jira/browse/YARN-6445
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-6445-YARN-3926.001.patch,
> YARN-6445-YARN-3926.002.patch, YARN-6445-YARN-3926.003.patch
>
>
> As part of the SLS runs on YARN-3926, we discovered a bunch of bottlenecks
> around object creation and garbage collection. This JIRA is to apply a fix
> for those bottlenecks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
