[ 
https://issues.apache.org/jira/browse/YARN-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982263#comment-15982263
 ] 

Carlo Curino commented on YARN-3663:
------------------------------------

[~giovanni.fumarola] thanks for addressing my comments. I understand all your 
answers, and I am ok to postpone some of the refactorings I asked (we should 
think a bit more about especially for {{SQLFederationStateStore}} point 7).

Overall the patch is +1, but please:
 # Open all the follow-up JIRAs we mentioned as sub-tasks of YARN-5597 
(federation v2)
 # Address the first 2 checkstyle ({{UTC_CALENDAR}})... I think it should be 
{{private}}, and the naming could be a standard {{utcCalendar}}.

Patch is good to commit once that is done. If you get it done tonight or 
tomorrow morning, I will commit it tomorrow late morning, otherwise I asked 
[~subru] to take-over reviewing and commit,
 as I will be traveling with limited connectivity for a few days.


> Federation State and Policy Store (DBMS implementation)
> -------------------------------------------------------
>
>                 Key: YARN-3663
>                 URL: https://issues.apache.org/jira/browse/YARN-3663
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-2915
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>         Attachments: YARN-3663-YARN-2915.v1.patch, 
> YARN-3663-YARN-2915.v2.patch, YARN-3663-YARN-2915.v3.patch
>
>
> This JIRA tracks a SQL-based implementation of the Federation State and 
> Policy Store, which implements YARN-3662 APIs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to