[
https://issues.apache.org/jira/browse/YARN-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710323#comment-13710323
]
Omkar Vinit Joshi commented on YARN-661:
----------------------------------------
bq. DeletionService.fileDeletionTaskFinished(): before successorTask gets
scheduled, you are checking for successorTask.getSucess(). Assuming current
task finished successfully, we don't set the success status on
successorTask(lines +288 - +290). And the default for success is false. So
successorTask won't even be scheduled when current task finishes ?! But the
test passes, confused. If the code is correct, comments will help.
No the default is "success=true". If say we have 3 dependent (predecessor)
tasks and 1 successor task and if any of the dependent task fails then in the
fileDeletionTaskFinished() routine it will set successor tasks's success as
false. Added comment in code.
bq. Add a test timeout for TestDeletionService.testFileDeletionTaskDependency
and remove unused imports.
yeah...fixed it.
bq. You have a System.out.println, must be for testing? Or you can convert it
into a log message.
:) yup ..for testing..moved it to debug logs.
> NM fails to cleanup local directories for users
> -----------------------------------------------
>
> Key: YARN-661
> URL: https://issues.apache.org/jira/browse/YARN-661
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.1.0-beta, 0.23.8
> Reporter: Jason Lowe
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-661-20130701.patch, YARN-661-20130708.patch,
> YARN-661-20130710.1.patch, YARN-661-20130711.1.patch,
> YARN-661-20130712.1.patch, YARN-661-20130715.1.patch
>
>
> YARN-71 added deletion of local directories on startup, but in practice it
> fails to delete the directories because of permission problems. The
> top-level usercache directory is owned by the user but is in a directory that
> is not writable by the user. Therefore the deletion of the user's usercache
> directory, as the user, fails due to lack of permissions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
