[
https://issues.apache.org/jira/browse/YARN-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986967#comment-15986967
]
Jason Lowe commented on YARN-3839:
----------------------------------
Thanks for updating the patch!
I don't believe we should remove the NMNotYetReadyException from the
ServeryProxy exception map. Otherwise if a newer client talks to an older
server that is still throwing the old exception then the new client will not
handle it gracefully.
Otherwise patch looks good. Please look a bit deeper into the test failures,
there may be races that are not going well once the check for the blocked
boolean was removed and now we're proceeding quicker than we would have before.
> Quit throwing NMNotYetReadyException
> ------------------------------------
>
> Key: YARN-3839
> URL: https://issues.apache.org/jira/browse/YARN-3839
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Karthik Kambatla
> Assignee: Manikandan R
> Attachments: YARN-3839.001.patch, YARN-3839.002.patch,
> YARN-3839.003.patch, YARN-3839.004.patch, YARN-3839.005.patch,
> YARN-3839.006.patch
>
>
> Quit throwing NMNotYetReadyException when NM has not yet registered with the
> RM.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
