[
https://issues.apache.org/jira/browse/YARN-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710383#comment-13710383
]
Bikas Saha commented on YARN-922:
---------------------------------
FileSystem API doc says mkdir is recursive and so we dont need these additional
RPC's
{code}
+ fs.mkdirs(fsWorkingPath);
+ fs.mkdirs(rootDirPath);
fs.mkdirs(rmDTSecretManagerRoot);
fs.mkdirs(rmAppRoot);
{code}
Please remove the print or use a log
{code}
+ assert appState != null;
+ System.out.println(attemptState.getAttemptId());
+ appState.attempts.put(attemptState.getAttemptId(), attemptState);
{code}
"public void addOrphanAttemptIfNeeded" has been used in the patch for ZKStore
in YARN-353. Are you sure you want to remove it here? It may not be needed if
we are using multi operations. Please double check.
Please use a helper method to get appDir etc in storeApp/storeAttempt/removeApp
instead of replicating the code.
> Change FileSystemRMStateStore to use directories
> ------------------------------------------------
>
> Key: YARN-922
> URL: https://issues.apache.org/jira/browse/YARN-922
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-922.1.patch, YARN-922.2.patch, YARN-922.patch
>
>
> Store each app and its attempts in the same directory so that removing
> application state is only one operation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
