[ https://issues.apache.org/jira/browse/YARN-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997673#comment-15997673 ]
Botong Huang edited comment on YARN-5531 at 5/5/17 12:59 AM: ------------------------------------------------------------- Thanks [~subru] for the comments! * We should Initialize threadpool in default constructor or in serviceStart (if null) ** threadpool is not a Yarn service, and not serviceStart needed * Shouldn't forceKillApplication check for Am registered state? ** forceKillApplication is in {{ApplicationClientProtocol}}, it simply kills the app if there. * There are quite a few throw RuntimeException which will exit the thread. Do we have any better options or is this fine? ** There's a catch Throwable at last :) * Can we reuse code in submitAppAndGetAppId, monitorApplicationSubmission, monitorCurrentAppAttempt & getApplicationReport with the existing UAM launcher here? ** It is a bit different because it goes throw YarnClient. There's quite some modifications needed to reuse that code. All the rest if fixed in v5 patch. was (Author: botong): Thanks [~subru] for the comments! * We should Initialize threadpool in default constructor or in serviceStart (if null) ** threadpool is not a Yarn service, and not serviceStart needed * Shouldn't forceKillApplication check for Am registered state? ** forceKillApplication is in {{ApplicationClientProtocol}}, it simply kills the app if there. * There are quite a few throw RuntimeException which will exit the thread. Do we have any better options or is this fine? ** There's a catch Throwable at last :) * Can we reuse code in submitAppAndGetAppId, monitorApplicationSubmission, monitorCurrentAppAttempt & getApplicationReport with the existing UAM launcher here? ** It is a bit different because it goes throw YarnClient. We need All the rest if fixed in v5 patch. > UnmanagedAM pool manager for federating application across clusters > ------------------------------------------------------------------- > > Key: YARN-5531 > URL: https://issues.apache.org/jira/browse/YARN-5531 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Subru Krishnan > Assignee: Botong Huang > Attachments: YARN-5531-YARN-2915.v1.patch, > YARN-5531-YARN-2915.v2.patch, YARN-5531-YARN-2915.v3.patch, > YARN-5531-YARN-2915.v4.patch, YARN-5531-YARN-2915.v5.patch > > > One of the main tenets the YARN Federation is to *transparently* scale > applications across multiple clusters. This is achieved by running UAMs on > behalf of the application on other clusters. This JIRA tracks the addition of > a UnmanagedAM pool manager for federating application across clusters which > will be used the FederationInterceptor (YARN-3666) which is part of the > AMRMProxy pipeline introduced in YARN-2884. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org