[ 
https://issues.apache.org/jira/browse/YARN-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999148#comment-15999148
 ] 

Yufei Gu edited comment on YARN-6560 at 5/5/17 11:53 PM:
---------------------------------------------------------

Looks good to me. +1 (non-binding). Don't worry about the unit test failure 
since it is due to the failure to parse rumen input.


was (Author: yufeigu):
Looks good to me. +1 (non-binding)

> SLS doesn't honor node total resource specified in sls-runner.xml
> -----------------------------------------------------------------
>
>                 Key: YARN-6560
>                 URL: https://issues.apache.org/jira/browse/YARN-6560
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-6560.1.patch, YARN-6560.2.patch
>
>
> Now SLSRunner extends ToolRunner, so setConf will be called twice: once in 
> the init() of SLSRunner and once in ToolRunner. The later one will overwrite 
> the previous one so it won't correctly load sls-runner.xml



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to