[ 
https://issues.apache.org/jira/browse/YARN-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000239#comment-16000239
 ] 

Haibo Chen commented on YARN-5067:
----------------------------------

Thanks [~yufeigu] for the patch! A few high-level comments.
1) Why make SLSConfiguration extend Configuration? The change seems unnecessary 
given that we can still use Configuration directly, unless I am missing 
something?
2) The patch does not apply cleanly now (a minor conflict)

> Support specifying resources for AM containers in SLS
> -----------------------------------------------------
>
>                 Key: YARN-5067
>                 URL: https://issues.apache.org/jira/browse/YARN-5067
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Yufei Gu
>         Attachments: YARN-5067.001.patch, YARN-5067.002.patch
>
>
> Now resource of application masters in SLS is hardcoded to mem=1024 vcores=1.
> We should be able to specify AM resources from trace input file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to