[
https://issues.apache.org/jira/browse/YARN-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001543#comment-16001543
]
Subru Krishnan commented on YARN-5413:
--------------------------------------
Thanks [~giovanni.fumarola] for the patch. I looked at it and have a few minor
comments:
* Please add a *Bind host* for the Router and use it for both client RM and
admin protocols.
* Can you look at reusing configs from client-RM, say LRUCache size.
* There's a typo, use RM_ADMIN_CLIENT_THREAD_COUNT instead of
RM_CLIENT_THREAD_COUNT.
* Can you link (@code/@link) the appropriate classes in Javadoc. This has to
be done for client-RM also.
* I see *getInterceptorClassNames/createRequestInterceptorChain* is being
used again. Can you create a JIRA to refactor this to common class as I feel it
can be done using templatization.
> Create a proxy chain for ResourceManager Admin API in the Router
> ----------------------------------------------------------------
>
> Key: YARN-5413
> URL: https://issues.apache.org/jira/browse/YARN-5413
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5413-YARN-2915.v1.patch
>
>
> As detailed in the proposal in the umbrella JIRA, we are introducing a new
> component that routes client request to appropriate ResourceManager(s). This
> JIRA tracks the creation of a proxy for ResourceManager Admin API in the
> Router. This provides a placeholder for:
> 1) throttling mis-behaving clients (YARN-1546)
> 3) mask the access to multiple RMs (YARN-3659)
> We are planning to follow the interceptor pattern like we did in YARN-2884 to
> generalize the approach and have only dynamically coupling for Federation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
