[
https://issues.apache.org/jira/browse/YARN-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005205#comment-16005205
]
Daniel Templeton edited comment on YARN-6571 at 5/10/17 6:50 PM:
-----------------------------------------------------------------
LGTM. +1 on the latest patch, pending a clean bill of health from Jenkins.
was (Author: templedf):
LGTM. +1 on the latest patch.
> Fix JavaDoc issues in SchedulingPolicy
> --------------------------------------
>
> Key: YARN-6571
> URL: https://issues.apache.org/jira/browse/YARN-6571
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Weiwei Yang
> Priority: Trivial
> Labels: newbie
> Attachments: YARN-6571.001.patch, YARN-6571.002.patch,
> YARN-6571.003.patch
>
>
> There are several javadoc issues:
> * Class JavaDoc is missing.
> * {{getInstance()}} is missing {{@return}} and {{@param}} tags.
> * {{parse()}} is missing {{@return}} tag and description for {{@throws}} tag.
> * {{checkIfUsageOverFairShare()}} is missing a period at the end of the first
> sentence.
> * {{getHeadroom()}} should use {code}{@code}{code} instead of {{<code>}} tags.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
